refactor: cleanup interviews #924

krantheman · 2023-09-28T07:53:57Z

Issue

Closes: #781

Changes

Redid Feedback section of the Interview DocType
- Eliminated data duplication by removing average rating, result, and other fields from the Interview Detail table. This table only has an Interviewer link field now.
- Added a Feedback tab that summarizes and displays data directly from Interview Feedback
Made Interview Type optional for Interview Round
Updated applicable interviewers to default to Interview Round Interviewers
Updated Submit Feedback button in Interview to be disabled, but visible, for unauthorized users (as opposed to not being rendered at all)
Fixed issue where cancellation of an individual Interview Feedback required all docs of the same Interview to be cancelled
Removed unnecessary overlap validation to allow for more flexibility
Updated tests to reflect changes
Updated Appraisal -> Feedback tab to use the same feedback summary & history templates as Interview -> Feedback

Documentation

https://frappehr.com/docs/v14/en/interview-management

hrms/public/scss/interview.scss

codecov-commenter · 2023-09-28T09:04:49Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (dfb9712) 72.48% compared to head (f935cb3) 72.26%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #924      +/-   ##
===========================================
- Coverage    72.48%   72.26%   -0.22%     
===========================================
  Files          201      201              
  Lines        10946    10941       -5     
===========================================
- Hits          7934     7907      -27     
- Misses        3012     3034      +22

Files	Coverage Δ
hrms/hooks.py	`100.00% <ø> (ø)`
...ms/hr/doctype/interview_detail/interview_detail.py	`100.00% <ø> (ø)`
...r/doctype/interview_feedback/interview_feedback.py	`93.18% <100.00%> (-0.94%)`	⬇️
hrms/hr/doctype/interview_round/interview_round.py	`38.88% <0.00%> (ø)`
hrms/hr/doctype/job_applicant/job_applicant.py	`64.28% <0.00%> (ø)`
hrms/hr/doctype/interview/interview.py	`64.41% <88.00%> (+0.44%)`	⬆️

... and 7 files with indirect coverage changes

ruchamahabal · 2023-10-03T08:00:35Z

make the feedback cards tighter - reduce padding
star distribution chart - remove colors - convert to gray (like appraisal feedback summary)
Font size for chart labels & rating - looks bigger than feedback font
Rating summary header font sizes should be consistent with section heading sizes
Tighter spacing in summary - between "based on x reviews" and the stars

Extra:

Reuse/change appraisal feedback template
Reduce spacing between section title & description

- retain interviewer mapping in child table in APIs

- user has to enter all fields again - before sending rescheduling email check if timings have changed

… non-employee users

hrms/hr/doctype/interview/interview.json

ruchamahabal · 2024-01-01T05:14:08Z

@Mergifyio backport version-15-hotfix

mergify · 2024-01-01T05:14:12Z

backport version-15-hotfix

❌ No backport have been created

Backport to branch version-15-hotfix failed

Git reported the following error:

error: commit 0ff94289cd53513b18ff88dd8e257aadc89bccee is a merge but no -m option was given.
fatal: cherry-pick failed

ruchamahabal · 2024-01-01T05:24:38Z

@Mergifyio copy version-15-hotfix

mergify · 2024-01-01T05:24:42Z

copy version-15-hotfix

❌ No copy have been created

Copy to branch version-15-hotfix failed

Git reported the following error:

error: commit 0ff94289cd53513b18ff88dd8e257aadc89bccee is a merge but no -m option was given.
fatal: cherry-pick failed

ruchamahabal · 2024-01-01T05:26:35Z

@krantheman can you open a PR on v15 hotfix

mergify · 2024-01-01T07:20:07Z

⚠️ The sha of the head commit of this PR conflicts with #1243. Mergify cannot evaluate rules on this PR. ⚠️

krantheman added 22 commits September 18, 2023 15:54

refactor(Interview Round): make Interview Type optional

3d2865d

feat: add Feedback Tab

07fd012

feat: pull feedback data from server

44bde3b

feat: add ratings summary

9e999e5

refactor: calculate reviews per rating based on user average rating

61b2520

feat: add individual ratings

11ed8f5

refactor: clean up feedback summary

8b13121

feat: add circular progress bar

389f4c8

feat: dynamic circular progress bar

77082ed

refactor: get appllicable interviewers

5e17df1

feat: use circular progress bar for skills

79e4465

feat: consider colors for ratings between 0 and 1

476e465

fix: circular progress size

47fe4e5

refactor: disable Submit Feedback for unauthorized users

e310415

feat: update interview average rating on submitting feedback

5314b38

refactor: clean up interview_details

b793e93

test: clean up instances of interview_detail

837c1c1

chore: delete redundant doctype Interview Detail

f7ac74a

refactor: better querying

4b5d6b2

fix: Feedback rendering of new Interviews

f7986bf

fix: No feedback message

3dc7641

fix: rounding

0553c71

krantheman changed the title ~~Cleanup interviews~~ refactor: cleanup interviews Sep 28, 2023

chore: remove unused import

0c8c05a

ruchamahabal reviewed Sep 28, 2023

View reviewed changes

hrms/public/scss/interview.scss Outdated Show resolved Hide resolved

krantheman added 2 commits September 28, 2023 13:59

fix: Feedback Summary subtext

d830b6a

chore: convert spaces to tabs ...again

c0912e6

chore: improve readability

8f53b54

ruchamahabal added 5 commits December 31, 2023 00:42

fix: run feedback functions serially

dc62f11

fix: don't break whitelisted API

501a41b

- retain interviewer mapping in child table in APIs

test: fix interview tests

fe0f9cd

feat: show hover message for disabled feedback submission

8ecd8b7

chore: cleanup templates

4efee05

ruchamahabal force-pushed the cleanup-interviews branch from d07573c to 4efee05 Compare December 31, 2023 15:49

ruchamahabal added 5 commits December 31, 2023 21:27

feat: set current interview timings as default while rescheduling

e48a0c5

- user has to enter all fields again - before sending rescheduling email check if timings have changed

fix: notify update after updating average rating in interview

285c2a2

fix: move Reschedule Interview to Actions

30e4f62

fix: use left join in interview feedback query to fetch feedback from…

7171f50

… non-employee users

test(APIs): get_feedback & get_skill_wise_average_rating

3309c6b

ruchamahabal force-pushed the cleanup-interviews branch from 2699e41 to 3309c6b Compare December 31, 2023 19:06

chore: remove unused col break

f935cb3

ruchamahabal reviewed Jan 1, 2024

View reviewed changes

hrms/hr/doctype/interview/interview.json Outdated Show resolved Hide resolved

chore: allow updating interview detail on submission

5bfca12

ruchamahabal approved these changes Jan 1, 2024

View reviewed changes

ruchamahabal merged commit e54baa4 into frappe:develop Jan 1, 2024
5 of 6 checks passed

ruchamahabal added backport version-15-hotfix and removed backport version-15-hotfix labels Jan 1, 2024

krantheman deleted the cleanup-interviews branch January 1, 2024 06:47

krantheman mentioned this pull request Jan 1, 2024

refactor: cleanup interviews (backport #924) #1243

Closed

gbinu42 mentioned this pull request Jan 2, 2024

Changing the title of a Job Opening does not change its url #1246

Closed

1 task

ruchamahabal mentioned this pull request Jan 3, 2024

refactor: cleanup interviews #1249

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: cleanup interviews #924

refactor: cleanup interviews #924

krantheman commented Sep 28, 2023 •

edited by ruchamahabal

Loading

codecov-commenter commented Sep 28, 2023 •

edited

Loading

ruchamahabal commented Oct 3, 2023 •

edited

Loading

ruchamahabal commented Jan 1, 2024

mergify bot commented Jan 1, 2024 •

edited

Loading

ruchamahabal commented Jan 1, 2024

mergify bot commented Jan 1, 2024 •

edited

Loading

ruchamahabal commented Jan 1, 2024

mergify bot commented Jan 1, 2024

refactor: cleanup interviews #924

refactor: cleanup interviews #924

Conversation

krantheman commented Sep 28, 2023 • edited by ruchamahabal Loading

Issue

Changes

Documentation

codecov-commenter commented Sep 28, 2023 • edited Loading

Codecov Report

ruchamahabal commented Oct 3, 2023 • edited Loading

ruchamahabal commented Jan 1, 2024

mergify bot commented Jan 1, 2024 • edited Loading

❌ No backport have been created

ruchamahabal commented Jan 1, 2024

mergify bot commented Jan 1, 2024 • edited Loading

❌ No copy have been created

ruchamahabal commented Jan 1, 2024

mergify bot commented Jan 1, 2024

krantheman commented Sep 28, 2023 •

edited by ruchamahabal

Loading

codecov-commenter commented Sep 28, 2023 •

edited

Loading

ruchamahabal commented Oct 3, 2023 •

edited

Loading

mergify bot commented Jan 1, 2024 •

edited

Loading

mergify bot commented Jan 1, 2024 •

edited

Loading